Fixed commit pagination code #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseusys
requested review from
anmol098,
MarkenJaden,
aravindvnair99 and
AndPuQing
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
|
README stats current output: 🐱 My GitHub Data
I'm an Early 🐤 📅 I'm Most Productive on Sunday 📊 This Week I Spent My Time On I Mostly Code in JavaScript Timeline You can use this website to view the generated base64 image. Last Updated on 11/08/2023 03:21:44 UTC |
|
Hello, @pseusys ! After I saw a real total number of commits in my profile from stats, which I use. I think, it's a correct number, because I haven't got so much number of commits. So, the real number of commits from stats is 431. |
|
@StasonMendelso, here's what I found:
|
|
In order to pull different images on different repository branches we have to modify this line so that:
In order to do that, we can:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I found (and hopefully fixed) pagination bug, that was found using @StasonMendelso hints and efforts.
Could you please check if the current version is correct (especially the commit count)?